On Tue, Feb 07, 2017 at 03:10:50PM +0100, Daniel Vetter wrote: > Noticed that everyone duplicates the same logic here and we could safe > a few lines per driver. Yay for lots of drivers to make such tiny > refactors worth-while! > > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Sean Paul <seanpaul@xxxxxxxxxxxx> > Cc: Noralf Trønnes <noralf@xxxxxxxxxxx> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 11 ++++------- > drivers/gpu/drm/armada/armada_fbdev.c | 2 -- > drivers/gpu/drm/ast/ast_fb.c | 9 +++------ > drivers/gpu/drm/bochs/bochs_fbdev.c | 5 +---- > drivers/gpu/drm/cirrus/cirrus_fbdev.c | 1 - > drivers/gpu/drm/drm_fb_cma_helper.c | 3 +-- > drivers/gpu/drm/drm_fb_helper.c | 16 ++++++++++++++-- > drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 -- > drivers/gpu/drm/gma500/framebuffer.c | 9 +++------ > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 3 +-- > drivers/gpu/drm/i915/intel_fbdev.c | 5 +---- > drivers/gpu/drm/mgag200/mgag200_fb.c | 5 +---- > drivers/gpu/drm/msm/msm_fbdev.c | 1 - > drivers/gpu/drm/nouveau/nouveau_fbcon.c | 1 - > drivers/gpu/drm/omapdrm/omap_fbdev.c | 4 ---- > drivers/gpu/drm/qxl/qxl_fb.c | 5 +---- > drivers/gpu/drm/radeon/radeon_fb.c | 11 ++++------- > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 9 +++------ > drivers/gpu/drm/tegra/fb.c | 5 +---- > drivers/gpu/drm/udl/udl_fb.c | 5 +---- > drivers/gpu/drm/virtio/virtgpu_fb.c | 5 +---- > include/drm/drm_fb_helper.h | 4 ---- > 22 files changed, 40 insertions(+), 81 deletions(-) > Driver changes look good. I'll echo Emil's comments about removing drm_fb_helper_release_fbi() from drm_fb_helper.c Sean <snip> -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
