Re: [PATCH 12/19] drm/i915: Remove bitmap tracking for used-ptes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 02, 2017 at 03:02:41PM +0000, Chris Wilson wrote:
> We only operate on known extents (both for alloc/clear) and so we can use
> both the knowledge of the bind/unbind range along with the knowledge of
> the existing pagetable to avoid having to allocate temporary and
> auxiliary bitmaps.

We're losing the ability to effectively track the entries though (as in we can
no longer do 'for each !empty entry do stuff' without iterating through the
whole table), which is why we need to drop the info from the tracepoint.

It would be nice if we could find that in the commit message. Maybe with a
different wording :)

Either way:
Reviewed-by: Michał Winiarski <michal.winiarski@xxxxxxxxx>

-Michał
 
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/i915_gem_gtt.c | 338 ++++++++++++------------------------
>  drivers/gpu/drm/i915/i915_gem_gtt.h |   5 +-
>  drivers/gpu/drm/i915/i915_trace.h   |  19 +-
>  3 files changed, 121 insertions(+), 241 deletions(-)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux