Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> On Thu, 2017-02-02 at 08:55 +0000, Chris Wilson wrote: > The alpha_support module option can only take one of two values, so > assign it to a boolean type. The only advantage is in pretty printing > via /sys/module/i915/parameters/alpha_support and elsewhere. > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Jani Nikula <jani.nikula@xxxxxxxxx> > Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx> > --- > drivers/gpu/drm/i915/i915_params.c | 2 +- > drivers/gpu/drm/i915/i915_params.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c > index 0e280fbd52f1..c2679fa7ed11 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -145,7 +145,7 @@ MODULE_PARM_DESC(enable_psr, "Enable PSR " > "(0=disabled, 1=enabled - link mode chosen per-platform, 2=force link-standby mode, 3=force link-off mode) " > "Default: -1 (use per-chip default)"); > > -module_param_named_unsafe(alpha_support, i915.alpha_support, int, 0400); > +module_param_named_unsafe(alpha_support, i915.alpha_support, bool, 0400); > MODULE_PARM_DESC(alpha_support, > "Enable alpha quality driver support for latest hardware. " > "See also CONFIG_DRM_I915_ALPHA_SUPPORT."); > diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h > index 668f88a79842..87ac6ed995d3 100644 > --- a/drivers/gpu/drm/i915/i915_params.h > +++ b/drivers/gpu/drm/i915/i915_params.h > @@ -44,7 +44,6 @@ typedef unsigned int param_uint; > func(param_int, enable_ppgtt); \ > func(param_int, enable_execlists); \ > func(param_int, enable_psr); \ > - func(param_uint, alpha_support); \ > func(param_int, disable_power_well); \ > func(param_int, enable_ips); \ > func(param_int, invert_brightness); \ > @@ -56,6 +55,7 @@ typedef unsigned int param_uint; > func(param_int, edp_vswing); \ > func(param_uint, inject_load_failure); \ > /* leave bools at the end to not create holes */ \ > + func(param_bool, alpha_support); \ > func(param_bool, enable_cmd_parser); \ > func(param_bool, enable_hangcheck); \ > func(param_bool, fastboot); \ _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx