From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> I've noticed a few opportunities to improve the readability of this functions and then kept spotting more and more which can be removed or compacted. Eventually ended up with removing i915_execbuffer_params completely. But I think it's OK since the plan between when it was added to now changed. Overall reduction in source and binary, hopefully for tidier code. text data bss dec hex filename 1085466 26398 2628 1114492 11017c i915.ko.0 1085290 26398 2628 1114316 1100cc i915.ko.1 Tvrtko Ursulin (10): drm/i915: Tidy i915_gem_do_execbuffer drm/i915: Drop some unused fields from i915_execbuffer_params drm/i915: Tidy execbuf_submit drm/i915: Remove batch field from i915_execbuffer_params drm/i915: Nuke i915_execbuffer_params drm/i915: Remove some single use locals i915_gem_do_execbuffer drm/i915: Drop unused engine parameter from i915_gem_validate_context drm/i915: eb_engine_select only needs flags drm/i915: Pass file_priv to eb_select_engine drm/i915: Remove some unecessary line breaks drivers/gpu/drm/i915/i915_gem_execbuffer.c | 159 +++++++++++------------------ 1 file changed, 60 insertions(+), 99 deletions(-) -- 2.7.4 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx