On Mon, Jan 30, 2017 at 12:18:07PM +0000, Eric Engestrom wrote: > On Monday, 2017-01-30 11:50:52 +0000, Daniel Stone wrote: > > Hi, > > > > On 30 January 2017 at 11:46, Petri Latvala <petri.latvala@xxxxxxxxx> wrote: > > > NAK. > > > > > > DRIVER_VGEM is omitted from DRIVER_ANY intentionally. Vgem is unable > > > to modeset, unable to render, practically it only supports the > > > vgem-specific tests. See also: lib/drmtest.c, __drm_open_driver(). > > > > Yeah, I agree with this. It's mostly just there as an auxiliary > > helper. Opening DRIVER_ANY to vgem means that, if you run on a system > > with vgem as well as a supported driver, you can end up with a > > near-100% skip rate if you don't explicitly specify the device, > > depending on device-load ordering. > > > > Cheers, > > Daniel > > OK. This should probably be documented then (a simple comment next to > the #define would go a long way), so that the next guy who see this > doesn't make the same mistake I did :) Maybe we should rename it to DRIVER_ANY_KMS, and check in the open function that there's at least 1 plane/crtc/encoder/connector there and otherwise skip? I think that would be even better than documenting it, since it'd also catch e.g. tegra+nouveau systems. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
