On Mon, 30 Jan 2017, Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> wrote:
> On ma, 2017-01-30 at 10:44 +0000, Chris Wilson wrote:
>> As we add new generations, we should keep detecting new pre-production
>> system development platforms that were temporarily enabled to facilitate
>> initial development and now superseded by production systems. To make
>> it easier to add more platforms, split the if into a series of logical
>> operations.
>>
>> v2: s/sdv/pre/ - not all system development vehicles are for
>> preproduction usage.
>>
>> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
>> Cc: "Zanoni, Paulo R" <paulo.r.zanoni@xxxxxxxxx>
>> Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
>> Cc: Jani Nikula <jani.nikula@xxxxxxxxx>
>> Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> <SNIP>
>
>> static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
>> {
>> - if (IS_HSW_EARLY_SDV(dev_priv) ||
>> - IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0))
>> + bool pre = false;
>> +
>> + pre |= IS_HSW_EARLY_SDV(dev_priv);
>> + pre |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
>
> Did you compare the asm with "pre = pre || ..."?
Yeah, this definitely needs to be optimized. :p
Acked-by: Jani Nikula <jani.nikula@xxxxxxxxx>
on the series.
>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
>
> Regards, Joonas
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
