On Mon, Jan 23, 2017 at 01:51:54PM +0000, Matthew Auld wrote: > On 14 January 2017 at 00:28, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > > It is only being used to clear a struct and set the type, after which it > > is overwritten. Since we no longer check the unset bits of the union, > > skipping the clear is permissible. > > > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > My machine is all of a sudden hanging just after boot and bisection > points to this as the culprit. When I revert back to the old behaviour > of copying from the zeroed struct for the normal case, then the issue > disappears, which doesn't make any sense. Any ideas? Quick diff of which clear you need? s/view->type = NORMAL;/ view = *i915_ggtt_view_normal; / ? -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
