Re: [PATCH 2/2] drm/i915/glk: Apply WaIncreaseDefaultTLBEntries on GLK.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 20, 2017 at 1:32 AM, Ander Conselvan De Oliveira
<conselvan2@xxxxxxxxx> wrote:
> On Thu, 2017-01-19 at 10:39 -0800, Rodrigo Vivi wrote:
>> According to wa_database this Wa persist on GLK as it was on BXT.
>>
>> Cc: Tim Gore <tim.gore@xxxxxxxxx>
>> Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxx>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@xxxxxxxxx>
>> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
>> ---
>>  drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
>> index cc0bb7b..332ca28 100644
>> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
>> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
>> @@ -2184,14 +2184,14 @@ static void gtt_write_workarounds(struct drm_i915_private *dev_priv)
>>        * called on driver load and after a GPU reset, so you can place
>>        * workarounds here even if they get overwritten by GPU reset.
>>        */
>> -     /* WaIncreaseDefaultTLBEntries:chv,bdw,skl,bxt,kbl */
>> +     /* WaIncreaseDefaultTLBEntries:chv,bdw,skl,bxt,kbl,glk */
>>       if (IS_BROADWELL(dev_priv))
>>               I915_WRITE(GEN8_L3_LRA_1_GPGPU, GEN8_L3_LRA_1_GPGPU_DEFAULT_VALUE_BDW);
>>       else if (IS_CHERRYVIEW(dev_priv))
>>               I915_WRITE(GEN8_L3_LRA_1_GPGPU, GEN8_L3_LRA_1_GPGPU_DEFAULT_VALUE_CHV);
>>       else if (IS_SKYLAKE(dev_priv) || IS_KABYLAKE(dev_priv))
>>               I915_WRITE(GEN8_L3_LRA_1_GPGPU, GEN9_L3_LRA_1_GPGPU_DEFAULT_VALUE_SKL);
>> -     else if (IS_BROXTON(dev_priv))
>> +     else if (IS_GEN9_LP(dev_priv))
>>               I915_WRITE(GEN8_L3_LRA_1_GPGPU, GEN9_L3_LRA_1_GPGPU_DEFAULT_VALUE_BXT);
>>  }
>>
>
> I wrote the same change in
>
> https://patchwork.freedesktop.org/patch/132807/

So please ignore this patch here.
I'm going to review yours.

Since you know what this is about, could you please review the KBL one?
https://patchwork.freedesktop.org/patch/134072/


>
>
> Ander
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux