Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes: > On Mon, Jan 16, 2017 at 04:03:16PM +0200, Mika Kuoppala wrote: >> Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes: >> >> > Now that we have prepare/finish routines for the GEM reset, move the >> > disabling of the engine->irq_tasklet into them to reduce repetition. The >> > device irq enable/disable is split out to ensure it is run first and >> > last always (even if the GPU reset fails). >> > >> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> >> > Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxx> >> >> As discussed briefly in irc, the disabling could be part of >> reset and enabling part of init_hw, that way we could wedge >> also with irq's off, even if it breaks the symmetry. > > We can't leave the irq off when wedged. It's the device IRQ, so hotplug, > gmbus and all sorts of transactions, not just our own user + > context-switch interrupts. Did you have something else in mind? Ah yes indeed that would be nasty for the display side. I was thinking that reset and whole hw init while irqs are off would be safer or more controlled. -Mika > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
