On ma, 2017-01-16 at 09:49 +0000, Chris Wilson wrote: > With the introduce of i915_vma_instance() for obtaining the VMA > singleton for a (obj, vm, view) tuple, we can remove the > i915_vma_create() in favour of a single entry point. We do incur a > lookup onto an empty tree, but the i915_vma_create() were being called > infrequently and during initialisation, so the small overhead is > negligible. > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> <SNIP> > struct i915_vma * > -i915_vma_create(struct drm_i915_gem_object *obj, > - struct i915_address_space *vm, > - const struct i915_ggtt_view *view); > - > -struct i915_vma * > i915_vma_lookup(struct drm_i915_gem_object *obj, > struct i915_address_space *vm, > const struct i915_ggtt_view *view); I'd say our de-facto is to drop "i915_" prefix from locals. Would add to the code understandability, but anyway; Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
