On ma, 2017-01-16 at 09:49 +0000, Chris Wilson wrote: > Whilst writing testcases to exercise the VMA API, some oddities came to > light, such as i915_gem_obj_lookup_or_create(). Joonas suggested > i915_vma_instance() as a neat replacement, so rename them, move them to > i915_vma.c and add some kerneldoc as a sugary bonus. > > s/i915_gem_obj_to_vma/i915_vma_lookup/ > s/i915_gem_obj_lookup_or_create_vma/i915_vma_instance/ > > Suggested-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> <SNIP> > +/** > + * i915_vma_lookup - finds a matching VMA > + * @obj - parent &drm_i915_gem_object to be mapped Before this circles back from the code checkers; s/ - /: /g Also extra space, and not sure if it was supposed to always be "&struct foo"? Didn't spot anything else, so with kerneldoc fixed; Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
