On pe, 2017-01-13 at 10:33 +0000, Chris Wilson wrote: > Reading the ggtt_views is much more pleasant without the extra > characters from specifying the union (i.e. ggtt_view.partial rather than > ggtt_view.params.partial). To make this work inside i915_vma_compare() > with only a single memcmp requires us to ensure that there are no > uninitialised bytes within each branch of the union (we make sure the > structs are packed) and we need to store the size of each branch. > > v4: Rewrite changelog and add comments explaining the assert. > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx