On 12/01/2017 10:35, Chris Wilson wrote:
When dumping the VMA, include the parameters of the different GGTT views
so that we can distinguish them.
Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>
---
drivers/gpu/drm/i915/i915_debugfs.c | 25 +++++++++++++++++++++++--
1 file changed, 23 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 9d7b5a8c8dea..54cdfcb926c7 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -159,8 +159,29 @@ describe_obj(struct seq_file *m, struct drm_i915_gem_object *obj)
seq_printf(m, " (%sgtt offset: %08llx, size: %08llx",
i915_vma_is_ggtt(vma) ? "g" : "pp",
vma->node.start, vma->node.size);
- if (i915_vma_is_ggtt(vma))
- seq_printf(m, ", type: %u", vma->ggtt_view.type);
+ if (i915_vma_is_ggtt(vma)) {
+ switch (vma->ggtt_view.type) {
+ case I915_GGTT_VIEW_NORMAL:
+ seq_puts(m, ", normal");
+ break;
+
+ case I915_GGTT_VIEW_PARTIAL:
+ seq_printf(m, ", partial offset %08llx + %x",
Maybe compact a bit, like "partial [%08llx+%x]" ?
+ vma->ggtt_view.params.partial.offset,
+ vma->ggtt_view.params.partial.size << PAGE_SHIFT);
+ break;
+
+ case I915_GGTT_VIEW_ROTATED:
+ seq_printf(m, ", rotated [0]=(%d, %d, %d) [1]=(%d, %d, %d)",
Type is %u, and maybe again compact like "rotated [[%ux%u, %u], [%ux%u,
%u]]"?
+ vma->ggtt_view.params.rotated.plane[0].width,
+ vma->ggtt_view.params.rotated.plane[0].height,
+ vma->ggtt_view.params.rotated.plane[0].stride,
+ vma->ggtt_view.params.rotated.plane[1].width,
+ vma->ggtt_view.params.rotated.plane[1].height,
+ vma->ggtt_view.params.rotated.plane[1].stride);
+ break;
+ }
Add default with MISSED_CASE and print the numerical representation?
+ }
if (vma->fence)
seq_printf(m, " , fence: %d%s",
vma->fence->id,
Overall this approach solves the concerns with the map solution I
proposed nicely. :)
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
