Re: [PATCH i-g-t v4 0/2] 32/64-bit ptr wrapper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 02, 2017 at 06:43:00AM -0500, Robert Foss wrote:
> 
> 
> On 2017-01-02 05:42 AM, Chris Wilson wrote:
> >On Mon, Jan 02, 2017 at 05:25:53AM -0500, Robert Foss wrote:
> >>Added and applied 32/64-bit wrapper for pointers used in ioctls.
> >>
> >>Robert Foss (2):
> >>  tests/perf: Fix pointer length compilation errors on 32-bit systems
> >>  lib/ioctl_wrappers.h: Add to_user_pointer() helper
> >
> >How come these ended up in igt with my sign-off? The patches are
> >backwards and do not complie cleanly (missed static on the inline and an
> >unneed cast since the u64 return provides the implicit cast).
> >-Chris
> 
> I interpreted your lgtm in v3 as a sign-off, obviously you did not
> intend that. Sorry about the nomenclature confusion.
> 
> Given that I slightly messed the push up, how would you like me to
> proceed? Fix the missed static and unneeded cast on a separate
> patch?

Already done.
There are a few more potential users of to_user_pointer() I haven't
checked over yet...
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux