On to, 2016-12-22 at 15:10 +0200, Ander Conselvan De Oliveira wrote: > > On Mon, 2016-12-19 at 19:28 +0200, ville.syrjala@xxxxxxxxxxxxxxx wrote: > > > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > Let's try to shrink intel_display.c a bit by moving the cdclk/rawclk > > stuff to a new file. It's all reasonably self contained so we don't > > even have to add that many non-static symbols. > > > > We'll also take the opportunity to shuffle around the functions a bit > > to get things in a more consistent order based on the platform. > > Hmm, maybe this is the moment to add some kerneldoc to this stuff, or Daniel > might be grumpy? :) > > The new file makes sense, didn't really check the move line by line, but > Would it be possible to create intel_cdclk.h header too? Untangling these headers bit by bit is much more fun than in panic once when it's really needed. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
