On Wed, 14 Dec 2016 13:55:52 +0100, Daniel Vetter wrote: > > Only noticed it here, but why again do we need to re-roll our intel-only > hdmi/eld notification? The one we have for hda is somewhat justified since > it went in at roughly the same time as the new shared one across a bunch > of soc. But this one here is just a reinvented wheel. > > And yes this code has been hanging around internally for years, but that's > kinda not a good excuse. > > Obviously this comment applies to patch 1 too. Yeah, a unified common interface would be better, really. I'm basically OK with the current implementation, though, as long as it works. But if we can sort it out quickly, it's better. That said, we may reuse i915_audio_component stuff -- or at least, reuse the object used there without actual component binding (the lpe driver doesn't need the component because it's a strong dependency unlike HD-audio case), and just add a few more fields there. Instead of exposing the resource, we can provide the register accessor there, too. It's just an idea, so not necessarily serious taken. But we can think of unification more easily now than later. BTW, now one thing came to my mind: don't we need the power control (pm and power well domain) when accessing from the sound driver side? The HD-audio component object has the gfx side callback points for such. thanks, Takashi _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
