On Tue, Dec 13, 2016 at 05:23:54PM +0200, Joonas Lahtinen wrote: > On ma, 2016-12-12 at 11:53 +0000, Chris Wilson wrote: > > Acknowledging that we were building up the hole was more useful to me > > when reading the code, than knowing the relationship between this node > > and the previous node. > > > > I don't really agree. I see that we have nodes and there are holes that > follow them, so prev_node makes more sense in that mindset. > > node->scanned_preceeds_hole = hole->hole_follows; and > hole->hole_follows = 1; look especially quirky to me when read aloud. Remnants of dead code that is summarily executed later on. The scanner is about tracking the hole generated by eviction, it is just that the prev_node holds the hole - so prev_node is just the pointer, the hole is the important detail (and fits in with the other code better). -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
