> On Fri, Dec 09, 2016 at 05:45:56PM +0200, Joonas Lahtinen wrote: > > On pe, 2016-12-09 at 18:01 +0800, Wang Elaine wrote: > > > From: Elaine Wang <elaine.wang@xxxxxxxxx> > > > > > > Some platforms don't have display. To avoid accessing the > > > non-existent registers, check whether num_pipes isn't zero before > > > invoking dispaly IRQ install or reset function. > > > > > > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > > > Signed-off-by: Elaine Wang <elaine.wang@xxxxxxxxx> > > > > Seems straightforward to me. A-b from Ville? > > Once upon a time we used HAS_PCH_NOP(). How does that differ? > -Chris There is no difference. HAS_PCH_NOP() is equal to INTEL_INFO(dev_priv)->num_pipes == 0. Let me modify the patch and use ! HAS_PCH_NOP() instead. Thanks, Elaine > > -- > Chris Wilson, Intel Open Source Technology Centre > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
