> On Wed, Dec 07, 2016 at 09:41:42PM +0200, Jani Nikula wrote: > > I see your point, and maybe I worry too much, but running stuff with a > > reloaded module is never the normal use case. This makes all the test > > run with a reloaded module. Currently, the reload tests are in positions 6-8 due to alphabetical ordering. Only igt@core_auth@basic-auth igt@core_prop_blob@basic igt@drv_getparams_basic@basic-eu-total igt@drv_getparams_basic@basic-subslice-total igt@drv_hangman@error-state-basic are run before drv_module_reload@* On Wed, Dec 07, 2016 at 08:09:07PM +0000, Chris Wilson wrote: > You can move the reload-inject to the end, but something I would > like for CI to start doing is not allowing i915 to load during the > boot. We miss error messages from that first load that do not appear > again later. :( > > That again is an unusual configuration (so we still need > initramfs/builtin checking). Combitorial explosions of combitorial > explosions. Yeah, several unusual configurations for several values of "unusual" exist, and it would be nice to have them tested. Given the choice of configurations to test in CI, I would prefer the usual one first, and unusual ones as much as resources allow. That given: > Anyway reload-final really should be the final operation irrespective of > this discussion :) We should move all drv_module_reload@* tests to the bottom really. That would make the other tests run in a usual configuration, and as a nice side-effect, with the admin-specified global module parameters (kernel cmdline, module config in /etc...). Those are currently ignored because of the reload (oopsie). Chris, Jani, comments on moving all reloads to the bottom? -- Petri Latvala _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
