On 08/12/2016 10:46, Jani Nikula wrote:
On Thu, 08 Dec 2016, Tvrtko Ursulin <tursulin@xxxxxxxxxxx> wrote:
From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Instead of listing them individually we can generate them
using the new i915_platforms.h header.
Also convert them to a static inline function which
interestingly makes the code smaller as well.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Cc: Jani Nikula <jani.nikula@xxxxxxxxx>
Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
NAK. Absolutely opposed to this.
Gee, sounds a bit to harsh to me. :) Didn't we say we are not doing NAKs
any longer?
A large part of my work involves digging through the source tree, and a
crucial part of that is looking up definitions and references, both for
macros and functions. Not having the macro/function definitions breaks
that workflow. Losing that, source code archeology gets *much*
harder. The losses are much greater than the gains.
Hm, I struggle to see that point on the same magnitude of a disaster
scale as you. I would have thought we all know what IS_SKYLAKE & co are
so it would be no big deal.
Imagine if we changed it to IS_PLATFORM(SKYLAKE) for instance.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
