Re: [PATCH] drm/i915: distinguish G33 and Pineview from each other

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 07 Dec 2016, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote:
> A lot of the checks involving g33 are apparently quite ugly. Might be
> nice to clean some of those up into a more readable form. But the
> patch looks correct so, and it looks like the rest of the IS_G33 checks
> already deal with PNV separately.

Agreed. But this is the required first step.

> I do wonder a bit about the IS_PINEVIEW_G and IS_PINEVIEW_M. I wonder if
> we should/could convert that to .is_mobile=true/false? Right now we seem
> to set .is_mobile=true for both.

Patches follow.

In the mean time, this one pushed, thanks for the review.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux