Hi Mika,
Thanks for respinning!
On 23 November 2016 at 11:49, Mika Kahola <mika.kahola@xxxxxxxxx> wrote:
> +bool kmstest_plane_visible(void)
> +{
> + char tmp[256];
> + FILE *fid;
> + bool visible = false;
> + struct kmstest_resolution resolution;
> + const char *mode = "r";
> + int ret;
> +
> + fid = igt_debugfs_fopen("i915_display_info", mode);
> +
> + igt_assert(fid != NULL);
This, however, breaks non-Intel drivers: we declare DRIVER_ANY, but
later assert that we can open this file. Maybe what would be better
would be to have:
void igt_assert_plane_visible(plane_id, should_be_visible)
which would then internally do an igt_assert() on the result, or
igt_skip() if that file is not present.
Also, it seems kind of fragile, as it only looks for the first plane
marked 'OVL'. What happens if we have multiple overlay planes?
Regardless, I think it's very close, and am happy to test a v3 on
non-i915. Thanks a lot for the rework!
Cheers,
Daniel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
