On Tue, Nov 29, 2016 at 09:29:06PM +0100, Daniel Vetter wrote: > On Tue, Nov 29, 2016 at 12:02:16PM +0000, Chris Wilson wrote: > > drm_fb_helper_probe_connector_modes() is always called before > > drm_setup_crtcs(), so just move the call into drm_setup_crtcs for a > > small bit of code compaction. > > > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> > > rb not entirely correct, since it's missing the crucial note I asked for > to understand things: > > "Note that register_framebuffer will do a modeset (when fbcon is enabled) > and hence must be moved out of the critical section. A follow-up patch > will add new locking for the fb list, hence move all the related > registration code together." Which is in patch 1 where the move was required. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
