On Tue, Nov 29, 2016 at 04:57:59PM +0000, Robert Bragg wrote: > Avoid using DRM_ERROR for conditions userspace can trigger with a bad > config when opening a stream or from not reading data in a timely > fashion (whereby the OA buffer fills up). These conditions are tested > by i-g-t which treats error messages as failures if using the test > runner. This wasn't an issue while the i915-perf igt tests were being > run in isolation. > > DRM_INFO was used over DRM_DEBUG since it's proven convenient while > working on gputop and mesa to have a message on the console for a > malformed config without needing to explicitly enable drm debug messages > which can be very verbose. The opposite. If they are only there for debugging userspace, make them debug. > One message relating to seeing a spurious zeroed report was changed to > use DRM_WARN instead of DRM_ERROR. Ideally this warning shouldn't be > seen, but it's not a serious problem if it is. Considering that the > tail margin mechanism is only a heuristic it's possible we might see > this from time to time. If it is expected and handled (i.e. has no impact on the driver), it is just a notice. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
