Op 28-11-16 om 10:37 schreef Abdiel Janulgue:
> Pretend to run on a non-intel machine even when running on i915.ko,
> so that we could run and gather passrate data.
> Signed-off-by: Abdiel Janulgue <abdiel.janulgue@xxxxxxxxxxxxxxx>
> ---
> lib/drmtest.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/lib/drmtest.c b/lib/drmtest.c
> index 44abc7e..a8b75e8 100644
> --- a/lib/drmtest.c
> +++ b/lib/drmtest.c
> @@ -254,8 +254,11 @@ int __drm_open_driver(int chipset)
> continue;
>
> if (chipset & DRIVER_INTEL && is_i915_device(fd) &&
> - has_known_intel_chipset(fd))
> + has_known_intel_chipset(fd)) {
> + igt_skip_on_f(getenv("IGT_GENERIC_ONLY"),
> + "Generic tests only\n");
> return fd;
> + }
This will make the passrate worse for any driver that has DRIVER_ANY set.
>
> if (chipset & DRIVER_VC4 &&
> is_vc4_device(fd))
> @@ -415,5 +418,6 @@ int drm_open_driver_render(int chipset)
>
> void igt_require_intel(int fd)
> {
> + igt_skip_on_f(getenv("IGT_GENERIC_ONLY"), "Generic tests only\n");
> igt_require(is_i915_device(fd) && has_known_intel_chipset(fd));
> }
>
Won't it be better to only put the hack in is_i915_device only?
Some code in IGT checks that too.
~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
