Op 22-11-16 om 21:28 schreef Lyude Paul:
> Reviewed-by: Lyude <lyude@xxxxxxxxxx>
>
> On Tue, 2016-11-22 at 22:21 +0200, ville.syrjala@xxxxxxxxxxxxxxx wrote:
>> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>>
>> Someone forgot to make skl_write_{plane,cursor}_wm() static when
>> removing the prototypes from the header. Sparse isn't pleased.
>>
>> Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
>> Cc: Lyude <cpaul@xxxxxxxxxx>
>> Cc: Matt Roper <matthew.d.roper@xxxxxxxxx>
>> Fixes: e62929b3f628 ("drm/i915/gen9+: Program watermarks as a
>> separate step during evasion, v3.")
>> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>> ---
>> drivers/gpu/drm/i915/intel_pm.c | 14 +++++++-------
>> 1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_pm.c
>> b/drivers/gpu/drm/i915/intel_pm.c
>> index bbb1eaf1e6db..d67974eb127a 100644
>> --- a/drivers/gpu/drm/i915/intel_pm.c
>> +++ b/drivers/gpu/drm/i915/intel_pm.c
>> @@ -3851,10 +3851,10 @@ static void skl_write_wm_level(struct
>> drm_i915_private *dev_priv,
>> I915_WRITE(reg, val);
>> }
>>
>> -void skl_write_plane_wm(struct intel_crtc *intel_crtc,
>> - const struct skl_plane_wm *wm,
>> - const struct skl_ddb_allocation *ddb,
>> - int plane)
>> +static void skl_write_plane_wm(struct intel_crtc *intel_crtc,
>> + const struct skl_plane_wm *wm,
>> + const struct skl_ddb_allocation *ddb,
>> + int plane)
>> {
>> struct drm_crtc *crtc = &intel_crtc->base;
>> struct drm_device *dev = crtc->dev;
>> @@ -3875,9 +3875,9 @@ void skl_write_plane_wm(struct intel_crtc
>> *intel_crtc,
>> &ddb->y_plane[pipe][plane]);
>> }
>>
>> -void skl_write_cursor_wm(struct intel_crtc *intel_crtc,
>> - const struct skl_plane_wm *wm,
>> - const struct skl_ddb_allocation *ddb)
>> +static void skl_write_cursor_wm(struct intel_crtc *intel_crtc,
>> + const struct skl_plane_wm *wm,
>> + const struct skl_ddb_allocation
>> *ddb)
>> {
>> struct drm_crtc *crtc = &intel_crtc->base;
>> struct drm_device *dev = crtc->dev;
Mea-culpa!
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
