>-----Original Message----- >From: Intel-gfx [mailto:intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx] On Behalf Of >Chris Wilson >Sent: Tuesday, November 22, 2016 9:06 AM >To: Hiler, Arkadiusz <arkadiusz.hiler@xxxxxxxxx> >Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx >Subject: Re: [PATCH] drm/i915/guc: Always initialize action_lock > >On Tue, Nov 22, 2016 at 05:22:47PM +0100, Arkadiusz Hiler wrote: >> Action lock is not being initialized if the GuC submission is disabled >> (i.e. i915.guc_submission=0). >> >> host2guc_action(), which uses the action_lock can be used for >> non-submission purposes, e.g. triggering HuC authentication. >> >> Moving action_lock initialization before enablement check will allow >> us to use the host2guc_action no matter whether submission is enabled >> or not. >> >> Cc: Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx> >> Cc: Jeff McGee <jeff.mcgee@xxxxxxxxx> >> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@xxxxxxxxx> > >Seems like you want to split uc_send(), uc_recv() out of i915_guc_submission.c - >Chris Hiler, this fixes the guc_loading enabled and guc_submission disabled scenario that I was facing. Anusha >-- >Chris Wilson, Intel Open Source Technology Centre >_______________________________________________ >Intel-gfx mailing list >Intel-gfx@xxxxxxxxxxxxxxxxxxxxx >https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
