On Fri, Nov 18, 2016 at 02:25:20PM +0200, Imre Deak wrote: > On pe, 2016-11-18 at 11:50 +0000, Chris Wilson wrote: > > On Fri, Nov 18, 2016 at 01:22:11PM +0200, Joonas Lahtinen wrote: > > > On ti, 2016-11-15 at 16:46 +0000, Chris Wilson wrote: > > > > @@ -218,7 +218,12 @@ static void i915_gem_request_retire(struct > > > > drm_i915_gem_request *request) > > > > */ > > > > list_del(&request->ring_link); > > > > request->ring->last_retired_head = request->postfix; > > > > - request->i915->gt.active_requests--; > > > > + if (!--request->i915->gt.active_requests) { > > > > > > BUG_ON(!request->i915->gt.active_requests) at the top? > > > > > > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > > > > Thanks. Hmm, this may catch that one-off report of > > GEM_BUG_ON(gt.awake) > > upon suspend. I don't think that made it to bugzilla. > > This one?: > https://bugs.freedesktop.org/show_bug.cgi?id=98670 That one. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx