Re: [PATCH i-g-t 3/4 v5] tests/drv_module_reload: Convert sh script to C version.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 03, 2016 at 06:36:45PM +0200, Jani Nikula wrote:
> On Thu, 03 Nov 2016, Marius Vlad <marius.c.vlad@xxxxxxxxx> wrote:
> > v5:
> > - reworked gem_info to gem_sanitychecks (Chris Wilson)
> > - remove subgroups/subtests for gem_exec_store and gem_sanitycheck
> > (Chris Wilson)
> >
> > v4:
> > - adjust test to make use of lib/igt_kmod
> > - replaced SW_FINISH with SET_CACHEING (Chris Wilson)
> >
> > v3:
> > - fix passing boolean value as flags to igt_kmod_unload().
> >
> > v2:
> > - embedded gem_alive and gem_exec_store into test (Chris Wilson)
> > - int main() to igt_main (Chris Wilson)
> > - moved tests/gem_alive -> tools/gem_info (Chris Wilson)
> > - added to intel-ci/fast-feedback.testlist (Petri Latvala)
> > - added hda_dynamic_debug() (Petri Latvala)
> > - renamed from tests/drv_module_reload_basic to tests/drv_module_reload
> > (all subtests are basic and have been added to fast-feedback.testlist)
> >
> > Signed-off-by: Marius Vlad <marius.c.vlad@xxxxxxxxx>
> 
> I'd like the merging of this patch be postponed until we have confidence
> that the snd_hda_intel module reload works in CI. It has been failing
> sporadically, so seeing just a couple of passing rounds after the latest
> fixes is not enough.

The module reloading has worked fine in CI lately. From that POV this
can go in now. However, the C version is missing the latest fixes to
the script version:

> > -		# unbind sound cards
> > -		for card in $(find /sys/bus/pci/drivers/snd_hda_intel -name "0000:*" -printf "%f\n"); do
> > -			echo $card > /sys/bus/pci/drivers/snd_hda_intel/unbind
> > -		done

This bit here, from fb957183105b08f058af331efe9f41ffc4128c6f, and some
debug output (lsmods, lsofs) from
b85e5a90862197b478d4f60cb0778fea71820de2 and
bd429cdc082748f1284ad987a867b502e5c8009f.


--
Petri Latvala
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux