>-----Original Message----- >From: Tvrtko Ursulin [mailto:tvrtko.ursulin@xxxxxxxxxxxxxxx] >Sent: Tuesday, November 15, 2016 2:31 AM >To: Srivatsa, Anusha <anusha.srivatsa@xxxxxxxxx>; Mcgee, Jeff ><jeff.mcgee@xxxxxxxxx> >Cc: Ursulin, Tvrtko <tvrtko.ursulin@xxxxxxxxx>; intel-gfx@xxxxxxxxxxxxxxxxxxxxx; >Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx> >Subject: Re: [PATCH] drm/i915/GuC: Combine the two kernel >parameter into one > > >On 14/11/2016 17:34, Srivatsa, Anusha wrote: > >[snip] > >>> One idea could be to hide the guc loading form the user altogether >>> and hence improve usability (decrease exposed complexity) by having >>> only two parameters; i915.enable_guc_scheduling and i915.enable_huc. >> That's a good point. But with this we will have two parameters (which kills the >point of why the patch was written in the first place), then we can rather leave it >the way it is. Right? > >For some reason I thought the HuC patch series add a another module >parameter. > >What is the failure mode for HuC is GuC firmware loading is disabled btw? Hi Tvrtko, in the function intel_guc_auth_huc() there is a check to see if GuC is loaded or not. If GuC loading has failed or loading is disabled, then HuC authentication does not happen. >Regards, > >Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
