On Tue, Nov 15, 2016 at 04:38:19PM +0200, Joonas Lahtinen wrote: > On ma, 2016-11-14 at 08:53 +0000, Chris Wilson wrote: > > +++ b/drivers/gpu/drm/i915/i915_vma.c > > @@ -53,6 +53,12 @@ i915_vma_retire(struct i915_gem_active *active, > > if (--obj->active_count) > > return; > > > > + /* Prune the shared fence arrays iff completely idle (inc. external) */ > > + ww_mutex_lock(&obj->resv->lock, NULL); > > + if (reservation_object_test_signaled_rcu(obj->resv, true)) > > + reservation_object_add_excl_fence(obj->resv, NULL); > > + ww_mutex_unlock(&obj->resv->lock); > > + > > This is not the first instance of "resv->lock" usage, but I think we > should not be doing that, and add reservation_* functions instead... But in the short term wrt to how we consume many, many more megabytes than we used to in gem_ctx_*.... -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
