On Thu, Nov 10, 2016 at 08:05:19AM +0000, Chris Wilson wrote:
> A raw pageflip is nonblocking and asynchronous, but
> kms_frontbuffer_tracking persumed that it was synchronous and completed
> before the funtion returns. It doesn't, so the CRC could be sampled
> before the flip completed.
>
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> ---
> tests/kms_frontbuffer_tracking.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
> index bc42701..343b124 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -122,7 +122,6 @@ struct test_mode {
> * and they exercise slightly different codepaths inside the Kernel. */
> enum flip_type {
> FLIP_PAGEFLIP,
> - FLIP_PAGEFLIP_EVENT,
> FLIP_MODESET,
> FLIP_PLANES,
> FLIP_COUNT,
> @@ -2322,11 +2321,6 @@ static void page_flip_for_params(struct modeset_params *params,
> switch (type) {
> case FLIP_PAGEFLIP:
> rc = drmModePageFlip(drm.fd, params->crtc_id,
> - params->fb.fb->fb_id, 0, NULL);
> - igt_assert_eq(rc, 0);
> - break;
> - case FLIP_PAGEFLIP_EVENT:
> - rc = drmModePageFlip(drm.fd, params->crtc_id,
> params->fb.fb->fb_id,
> DRM_MODE_PAGE_FLIP_EVENT, NULL);
> igt_assert_eq(rc, 0);
This makes FLIP_PAGEFLIP pass DRM_MODE_PAGE_FLIP_EVENT. Is that intentional?
--
Petri Latvala
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
