On Tue, Nov 08, 2016 at 03:30:33PM +0000, Chris Wilson wrote: > On Tue, Nov 08, 2016 at 04:47:19PM +0200, ville.syrjala@xxxxxxxxxxxxxxx wrote: > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > With plane->plane now purely reserved for the primary planes, let's > > not even populate it for cursors and sprites. Let's switch the type > > to enum plane as well since it's no longer being abused for anything > > else. > > Also suggests not starting enum plane from zero. That would complicate the DSPCNTR() etc. macros a bit. Also I think for gen2/3 I'll be wanting to index watermark related structs and whatnot with enum plane rather than enum plane_id since the planes<->pipe mapping isn't fixed. So a non-zero base might make life a bit more difficult. -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
