On Mon, Nov 07, 2016 at 10:54:43AM +0000, Chris Wilson wrote: > When we split a large object up into chunks for GTT faulting (because we > can't fit the whole object into the aperture) we have to align our cuts > with the fence registers. Each partial VMA must cover a complete set of > tile rows or the offset into each partial VMA is not aligned with the > whole image. Currently we enforce a minimum size on each partial VMA, > but this minimum size itself was not aligned to the tile row causing > distortion. > > Reported-by: Andreas Reis <andreas.reis@xxxxxxxxx> > Reported-by: Chris Clayton <chris2553@xxxxxxxxxxxxxx> > Reported-by: Norbert Preining <preining@xxxxxxxx> > Tested-by: Norbert Preining <preining@xxxxxxxx> > Fixes: 03af84fe7f48 ("drm/i915: Choose partial chunksize based on tile row size") > Fixes: a61007a83a46 ("drm/i915: Fix partial GGTT faulting") # enabling patch > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98402 > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> > Cc: <drm-intel-fixes@xxxxxxxxxxxxxxxxxxxxx> # v4.9-rc1+ Testcase: igt/gem_mmap_gtt/medium-copy-odd Appears quite difficult to actually aim for. I was expecting the huge-copy to be the main test case (since its objects can never fit) - not sure why it still passes. Still we manage to it with one of them! -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx