Re: [PATCH] drm: move allocation out of drm_get_format_name()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 05.11.2016 um 02:33 schrieb Eric Engestrom:
+typedef char drm_format_name_buf[32];

Please don't use a typedef for this, just define the maximum size of characters the function might write somewhere.

See the kernel coding style as well:
In general, a pointer, or a struct that has elements that can reasonably
be directly accessed should **never** be a typedef.

Regards,
Christian.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux