On 03/11/2016 12:28, Chris Wilson wrote:
On Thu, Nov 03, 2016 at 10:47:54AM +0000, Tvrtko Ursulin wrote:
On 02/11/2016 17:50, Chris Wilson wrote:
@@ -600,9 +598,8 @@ static void intel_lrc_irq_handler(unsigned long data)
static void execlists_submit_request(struct drm_i915_gem_request *request)
{
struct intel_engine_cs *engine = request->engine;
- unsigned long flags;
- spin_lock_irqsave(&engine->execlist_lock, flags);
Again I am confused why this wasn't just _bh.
We may be in hardirq context here (normally, from just i915, we are
not). At the very least irqs are disabled here making spin_unlock_bh()
veboten.
Blast, I thought softirq are a subset of hardirq. :) On looking at the
code I see it is not implemented at all like that. Apart from sometimes. :)
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
