Re: [PATCH] i915/GuC: Make GuC loads default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Could someone please ack this? We need this before getting HuC.

GuC submission has regressions so the submission is not getting enabled.
But we need to have GuC loaded to be able to use HuC.

Thanks,
Rodrigo.

On Thu, Oct 6, 2016 at 11:08 AM, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> wrote:
> I also asked that same question many times. Maybe they can be unified
> later when we enable submission by default, but right now I believe
> this is the way to go, so
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
>
>
> On Thu, Oct 6, 2016 at 11:03 AM, Srivatsa, Anusha
> <anusha.srivatsa@xxxxxxxxx> wrote:
>>
>>
>>>-----Original Message-----
>>>From: Chris Wilson [mailto:chris@xxxxxxxxxxxxxxxxxx]
>>>Sent: Wednesday, October 5, 2016 11:57 PM
>>>To: Srivatsa, Anusha <anusha.srivatsa@xxxxxxxxx>
>>>Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
>>>Subject: Re:  [PATCH] i915/GuC: Make GuC loads default
>>>
>>>On Wed, Oct 05, 2016 at 04:20:04PM -0700, Anusha Srivatsa wrote:
>>>> Proper functioning of HuC requires GuC to be loaded. Make GuC loads
>>>> default so that HuC works seemlessly.
>>>> Also, note that GuC submission is not made default and still needs to
>>>> be given as a kernel parameter.
>>>> Once the issues around GuC submission is resolved it is intended to
>>>> make it default as well.
>>>
>>><broken record>Why is this even a separate parameter?</> -Chris
>>
>> It is a separate parameter because HuC requires GuC to be loaded. It is ok if command submission is not happening through GuC but GuC "has to" be loaded for HuC to function. Guc_submission parameter enables the command submission through GUC. But, guc_loading parameter ensures not only that the GuC is loaded but also that HuC can now function.
>>
>> Anusha
>>>--
>>>Chris Wilson, Intel Open Source Technology Centre
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>
>
> --
> Rodrigo Vivi
> Blog: http://blog.vivi.eng.br



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux