Em Qui, 2016-10-27 às 10:31 +0200, Maarten Lankhorst escreveu: > Op 27-10-16 om 09:12 schreef Daniel Vetter: > > > > On Wed, Oct 26, 2016 at 03:41:29PM +0200, Maarten Lankhorst wrote: > > > > > > Changes since v1: > > > - Remove plane->pipe checks, they're implied by the macros. > > > - Split unrelated changes to a separate commit. > > > > > > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.c > > > om> > > Drive-by review: The above commit message is way too thin. It > > prepares for > > something, but I can't make any connection at all to that > > something. 1-2 > > sentences about why are needed here I think. > > Hm, seems to have been lost somewhere. It was on my previous > submission: > > Caching is not required, drm_atomic_crtc_state_for_each_plane_state > can be used to inspect all plane_states that are assigned to the > current crtc_state, so we can just recalculate every time. My review of v1 also complained about the commit message, so I got surprised by seeing it just go away in v2. If my understanding of the code is correct, I think the text would make more sense if it was rewritten to: Caching is not required, drm_atomic_crtc_state_for_each_plane_state can be used to inspect the states of all planes assigned to the CRTC even if they are not part of crtc_state, so we can just recalculate every time. But feel free to not use the text above if you think it's not completely accurate. With the commit message problem solved somehow: Reviewed-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> > > ~Maarten > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
