Re: [PATCH 1/1] drm/i915: Give write permission to gt_boost_freq_mhz

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 24, 2016 at 03:43:02PM +0530, Kamble, Sagar A wrote:
> Hi Daniel, Chris,
> 
> 
> Sorry for not clarifying the purpose and if any misunderstanding.
> This was to allow running at fixed frequency.
> 
> Kindly clarify if it is intentional to have _store routine without S_IWUSR.
> 
> On 10/24/2016 2:42 PM, Chris Wilson wrote:
> > On Mon, Oct 24, 2016 at 11:05:13AM +0200, Daniel Vetter wrote:
> > > On Mon, Oct 24, 2016 at 10:00:49AM +0530, Sagar Arun Kamble wrote:
> > > 
> > > And uabi change with 0 commit message. This needs to be _much_ better ;-)
> > A case where the author cut'n'paste the wrong thing because he can't
> > read S_INCOMPREHENSIBLELINENOISE as opposed to the traditional 0600.

Oh, if it's a bugfix, then it should come with a Fixes: line, preferrably
generated using dim fixes.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux