On Mon, Oct 24, 2016 at 11:05:13AM +0200, Daniel Vetter wrote: > On Mon, Oct 24, 2016 at 10:00:49AM +0530, Sagar Arun Kamble wrote: > > And uabi change with 0 commit message. This needs to be _much_ better ;-) Also the patch subject isn't really useful: It's a literal translation from the patch to Enlish, which adds nothing. Much better to summarize a patch in terms of impacts and goals, e.g. "Allow userspace to set gpu boost". Plus of course then explain in the commit message why that is a good idea, why we need it, testcase and userspace for this and all this stuff. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx