Op 21-10-16 om 00:09 schreef Matt Roper: > On Wed, Oct 12, 2016 at 03:28:21PM +0200, Maarten Lankhorst wrote: >> This is the last bit required for making nonblocking modesets work >> correctly. The state in intel_crtc->hw_ddb is not updated until >> somewhere in atomic commit, while the previous crtc state should be >> accurate if the ddb hasn't changed. >> >> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> > Can we get rid of hw_ddb completely and always pull from old state? It > looks like the only other place it's still used is > skl_update_crtcs() -> skl_ddb_allocation_overlaps(). Probably as a followup patch. I kept it only for that reason indeed. I suppose it could be changed to if (updated) state = new_state->ddb else state = old_state->ddb. _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx