On Tue, Oct 18, 2016 at 10:51:53AM +0100, John Harrison wrote:
> On 14/10/2016 13:18, Chris Wilson wrote:
> >@@ -338,11 +345,10 @@ i915_gem_get_tiling(struct drm_device *dev, void *data,
> > case I915_TILING_Y:
> > args->swizzle_mode = dev_priv->mm.bit_6_swizzle_y;
> > break;
> >+ default:
> > case I915_TILING_NONE:
> > args->swizzle_mode = I915_BIT_6_SWIZZLE_NONE;
> > break;
> >- default:
> >- DRM_ERROR("unknown tiling mode\n");
> Why is this change still needed? Now that it returns early on lookup
> failure, there should be no need to ignore broken/unsupported tiling
> modes. So why silence the error message?
We do not emit *ERROR* (a driver error) under direct control of the
user.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
