Re: [PATCH igt] igt: drop gem_storedw_loop from BAT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 19, 2016 at 08:26:17PM +0100, Chris Wilson wrote:
> The inter-engine synchronisation (with and without semaphores) is
> equally exercised by gem_sync, so leave gem_storedw_loop out of the
> "quick" set.


How equally is "equally"? Is the test actually redundant, should it be
removed altogether?


--
Petri Latvala





> 
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> ---
>  tests/gem_storedw_loop.c              | 6 +++---
>  tests/intel-ci/fast-feedback.testlist | 7 -------
>  2 files changed, 3 insertions(+), 10 deletions(-)
> 
> diff --git a/tests/gem_storedw_loop.c b/tests/gem_storedw_loop.c
> index 317b8c6..4f05b21 100644
> --- a/tests/gem_storedw_loop.c
> +++ b/tests/gem_storedw_loop.c
> @@ -185,14 +185,14 @@ igt_main
>  	}
>  
>  	for (e = intel_execution_engines; e->name; e++) {
> -		igt_subtest_f("basic-%s", e->name) {
> +		igt_subtest_f("short-%s", e->name) {
>  			check_test_requirements(fd, e->exec_id);
> -			store_test(fd, e->exec_id | e->flags, 16*1024);
> +			store_test(fd, e->exec_id | e->flags, 4*1024);
>  		}
>  
>  		igt_subtest_f("long-%s", e->name) {
>  			check_test_requirements(fd, e->exec_id);
> -			store_test(fd, e->exec_id | e->flags, 1024*1024);
> +			store_test(fd, e->exec_id | e->flags, 4*1024*1024);
>  		}
>  	}
>  
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index 853b911..b8fce59 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -111,13 +111,6 @@ igt@gem_ringfill@basic-default
>  igt@gem_ringfill@basic-default-forked
>  igt@gem_ringfill@basic-default-hang
>  igt@gem_ringfill@basic-default-interruptible
> -igt@gem_storedw_loop@basic-blt
> -igt@gem_storedw_loop@basic-bsd
> -igt@gem_storedw_loop@basic-bsd1
> -igt@gem_storedw_loop@basic-bsd2
> -igt@gem_storedw_loop@basic-default
> -igt@gem_storedw_loop@basic-render
> -igt@gem_storedw_loop@basic-vebox
>  igt@gem_sync@basic-all
>  igt@gem_sync@basic-each
>  igt@gem_sync@basic-many-each
> -- 
> 2.9.3
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux