On Fri, 14 Oct 2016, Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx> wrote: > On 14/10/2016 14:31, Jani Nikula wrote: >> On Thu, 13 Oct 2016, Tvrtko Ursulin <tursulin@xxxxxxxxxxx> wrote: >>> From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> >>> >>> unsigned long is too wide - use smaller types in >>> struct cxsr_latency to save 800-something bytes of .rodata. >>> >>> v2: All data even fits in u16 for even more saving. (Ville Syrjala) >>> v3: Move bitfields to the end of the struct. (Joonas Lahtinen) >>> >>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> >>> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> >> Please learn how to run sparse, make it a habit to run it on your local >> branches before submitting patches, and make it a rule to run it before >> pushing patches. dim has helpers for this. > > Yeah I saw that you added dim sparse this week, however it only runs if > the dim tree is used for building it seems. > > I will try to figure out how to run in a separate build tree. There was 'dim checker' before, and now also 'dim sparse'. Both do the builds in the current directory, and do not cd to drm-intel directories, so they can be used independent of other dim stuff. In any case, running sparse is just a matter of having sparse in PATH, and building using make C=1 or C=2. The former will run sparse on just the files that need to be recompiled, the latter on everything. See also 'make help'. The helpers in dim first touch the the sources or rm the object files, and run C=1. >> The following is caused by this patch, fix or revert ASAP. > > Fix sent, you are on cc. Thanks. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
