On 14.08.2015 08:18, Zhang, Xiong Y wrote: >> On Mon, Aug 10, 2015 at 06:23:19PM +0000, Rodrigo Vivi wrote: >>> I believe this function could be added along with the next patch that >>> is the first to use it... >>> Or it would be good to have a good commit message explaining why this >>> function is needed and what is be used for... >> >> Yes, please don't split up patches so much that you end up adding dead code >> or dead structures - always try to have at least a minimal user for something. >> >> If you want to split things up really tiny then go the other way round: >> First add the callers, then add the implementation. That way reviewers can >> understand the big scope first and then dig into details. But this one here really >> is small enough to just be squashed in. >> -Daniel >> > [Zhang, Xiong Y] Thanks for teaching me how to handle this. I'll follow it in the next version. > thanks Was there a second version that got submitted? I can't find it if so. -- t _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
