Re: [PATCH] drm/i915: Unalias obj->phys_handle and obj->userptr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 03, 2016 at 10:18:03AM +0300, Joonas Lahtinen wrote:
> On pe, 2016-09-30 at 18:31 +0100, Chris Wilson wrote:
> > We use obj->phys_handle to choose the pread/pwrite path, but as
> > obj->phys_handle is a union with obj->userptr, we then mistakenly use
> > the phys_handle path for userptr objects within pread/pwrite.
> > 
> > Testcase: igt/gem_userptr_blits/forbidden-operations
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97519
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> 
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>

Commmented already on irc, but I totally panicked about this one. I think
we need an ops->pwrite.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux