On Wed, Oct 12, 2016 at 09:43:02AM +0100, Tvrtko Ursulin wrote: > > On 12/10/2016 09:17, David Weinehall wrote: > > On Tue, Oct 11, 2016 at 02:21:36PM +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin<tvrtko.ursulin@xxxxxxxxx> > > > > > > More .rodata string saving by avoid __I915__ magic inside WARNs. > > > > > > v2: Add parantheses around dev_priv. (Ville Syrjala) > > > > > > Signed-off-by: Tvrtko Ursulin<tvrtko.ursulin@xxxxxxxxx> > > Reviewed-by: David Weinehall<david.weinehall@xxxxxxxxxxxxxxx> > > > > Note that once this patch series goes in (or before), > > we should have a patch that turns intel_hdmi_to_dev() into > > intel_hdmi_to_dev_priv(). If you look at the code in > > intel_hdmi.c, almost every (after the dev -> dev_priv transition > > I think it's every) instance where it's used converts > > dev immediately further to dev_priv. > > Agreed, but best left for later I think. And there is more of those > opportunities throughout the code which I spotted while doing this. > > Regards, > > Tvrtko > > P.S. For some reason reply to all from thunderbird keeps dropping you from > the recipients. I might forget to manually add you. That's because my e-mail client sets the Mail-Followup-To header; I'm subscribed to the list -- I don't need duplicate copies addressed directly to me. Regards, David _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx