On Fri, 07 Oct 2016, Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> wrote: > On to, 2016-10-06 at 16:36 +0300, ville.syrjala@xxxxxxxxxxxxxxx wrote: >> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> >> >> debugfs_wedged and drm_lib.sh are already using bashism so switch >> over >> to using #!/bin/bash instead of #!/bin/sh. >> >> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Just reminds me of my RFC to convert them all to #!/bin/sh. The final > resolution was that all the scripts will be converted into C programs > shortly, there was even a JIRA created for it, Daniel? The "change" to use bash just reflects current reality. All the changes here look simple and sane, and immediately improve the results. The work is already done, no use blocking them because someone might eventually rewrite them in C. (And it will be a PITA to write the module reload test in C, so I wouldn't hold my breath.) For the series, Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> PS. When I look at IGT and the macro/setjmp/longjmp magic to create the test/subtest/fixture infrastructure, making the tests look like they've been written in some extended version of C, I have to question whether C really is the right language for the tests. libdrm python bindings and python, anyone? -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
