On Thu, Oct 06, 2016 at 03:17:45PM +0300, Jani Nikula wrote:
> On Thu, 06 Oct 2016, ville.syrjala@xxxxxxxxxxxxxxx wrote:
> > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> >
> > Leave the normal "executing" and "exiting" breadcrumbs into dmesg when
> > running the test.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> > ---
> > tests/drv_module_reload_basic | 27 +++++++++++++++++++++++++++
> > 1 file changed, 27 insertions(+)
> >
> > diff --git a/tests/drv_module_reload_basic b/tests/drv_module_reload_basic
> > index 93cf7c005638..4c75f0e9614a 100755
> > --- a/tests/drv_module_reload_basic
> > +++ b/tests/drv_module_reload_basic
> > @@ -6,6 +6,33 @@
> > #
> >
> > SOURCE_DIR="$( dirname "${BASH_SOURCE[0]}" )"
> > +
> > +NAME=$(basename "$0")
> > +
> > +KERN_EMER="<0>"
> > +KERN_ALERT="<1>"
> > +KERN_CRIT="<2>"
> > +KERN_ERR="<3>"
> > +KERN_WARNING="<4>"
> > +KERN_NOTICE="<5>"
> > +KERN_INFO="<6>"
> > +KERN_DEBUG="<7>"
> > +
> > +function kmsg()
> > +{
> > + echo "$1" > /dev/kmsg
> > +}
> > +
>
> Seems like these would belong in drm_lib.sh. Or do you really need to do
> the kmsg *before* sourcing drm_lib.sh?
drm_lib.sh can itself exit, so the trap needs to be done before sourcing
it. And drm_lib.sh isn't a bash script, so I didn't dare to put it
there.
>
> BR,
> Jani.
>
> > +function finish()
> > +{
> > + exitcode=$?
> > + kmsg "$KERN_INFO$NAME: exiting, ret=$exitcode"
> > + exit $exitcode
> > +}
> > +trap finish EXIT
> > +
> > +kmsg "$KERN_INFO$NAME: executing"
> > +
> > . $SOURCE_DIR/drm_lib.sh
> >
> > # no other drm service should be running, so we can just unbind
>
> --
> Jani Nikula, Intel Open Source Technology Center
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
