On Thu, Oct 06, 2016 at 11:07:17AM +0200, Daniel Vetter wrote: > At least when testing the kernel. In normal programs pretty much all > the dmesg noise would simply be replaced by debug asserts, but in the > kernel we try rely hard to not fall over minor inconsistencies. > > Still for CI purposes there's not really a difference, hence don't > treat it as such. > > Motivated since once again I've seen a statistics where this was split > up, and then a reduction of "failures" (but in reality just trading > them in for more "warnings") praised as success. > > Cc: jari.tahvanainen@xxxxxxxxx > Cc: Petri Latvala <petri.latvala@xxxxxxxxx> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> > --- > tests/igt.py | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tests/igt.py b/tests/igt.py > index 7ebb03646b50..473027b76936 100644 > --- a/tests/igt.py > +++ b/tests/igt.py > @@ -53,6 +53,7 @@ def check_environment(): > > """ > debugfs_path = "/sys/kernel/debug/dri" > + > if os.getuid() != 0: > raise exceptions.PiglitInternalError( > "Test Environment check: not root!") > @@ -123,6 +124,10 @@ class IGTTest(Test): > else: > self.result.result = 'fail' > > + # all dmesg noise is considered a test failure when testing the kernel > + if self.result.dmesg > + self.result.result = 'fail' Hmm. So now all errors will look the same? I think I'm usually more interested in the dmesg warns, so this would perhaps make it harder for me to spot them. Not sure I like that. > + > > def list_tests(listname): > """Parse igt test list and return them as a list.""" > -- > 2.9.3 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
